Preserve the timezone of the source when returning the time object #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAICT this PR also fixes a major bug: the cron parser skips the "fallback" hour of DST because the |
|
Without the PR: |
|
Awesome. Glad to hear that the timezone addition fixes DST issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this handy gem.
For my use case, I needed to be able to support a source time with a time zone that is different from the local one. This change preserves the time zone on the returned time object.
This breaks the use case where an alternate
time_sourceclass is passed in that does not support thenewmethod with the same signature as the one forTime.new.